docs: Add comment about the generation of no-answer samples in FARMReader training #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @brandenchan could you rebase with main to fix the schema check error? We just merged a PR that should fix this. |
sjrl
reviewed
Oct 17, 2022
…ck into reader_train_no_answer
Co-authored-by: Sebastian <[email protected]>
|
Hey @brandenchan just as a heads up the additional lines changed in the json schema shown by github under Files Changed are erroneous (since those changes are already in main). This is an issue on Githubs side that can happen after rebasing a branch. This Stack Overflow post explains the situation and a workaround. |
agnieszka-m
reviewed
Oct 17, 2022
haystack/nodes/reader/farm.py
Outdated
| @@ -377,6 +377,9 @@ def train( | |||
| Checkpoints can be stored via setting `checkpoint_every` to a custom number of steps. | |||
| If any checkpoints are stored, a subsequent run of train() will resume training from the latest available checkpoint. | |||
|
|
|||
| Note that when performing training with this function, long documents are split into chunks. | |||
| If a chunk does not contain the answer to the question, it is treated as a no-answer sample. | |||
There was a problem hiding this comment.
Suggested change
| If a chunk does not contain the answer to the question, it is treated as a no-answer sample. | |
| If a chunk doesn'tt contain the answer to the question, it is treated as a no-answer sample. |
…der_train_no_answer # Conflicts: # haystack/nodes/reader/farm.py
agnieszka-m
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Checklist