Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multi-platform Docker images #3354

Merged
merged 6 commits into from
Oct 11, 2022
Merged

feat: add multi-platform Docker images #3354

merged 6 commits into from
Oct 11, 2022

Conversation

masci
Copy link
Contributor

@masci masci commented Oct 10, 2022

Related Issues

  • fixes n/a

Proposed Changes:

Build the new Docker images for both amd64 and arm64 architectures

How did you test it?

Notes for the reviewer

  • The target "docker-metadata-action" was removed because a leftover from an old Github action setup

Checklist

@masci masci requested review from a team as code owners October 10, 2022 10:41
@masci masci requested review from ZanSara and removed request for a team October 10, 2022 10:41
@julian-risch julian-risch requested review from julian-risch and removed request for ZanSara October 11, 2022 09:33
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me! 👍 I very much like the comment "A note about multi-platform builds..." explaining the error message that some users might get in advance. Very forward-thinking! 👍

@masci masci merged commit 8ddb6d7 into main Oct 11, 2022
@masci masci deleted the massi/docker-platforms branch October 11, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants