Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove Inferencer multiprocessing #3283

Merged
merged 4 commits into from
Oct 4, 2022
Merged

refactor: remove Inferencer multiprocessing #3283

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbbc3c4
Remove Inferencer multiprocessing
vblagoje Sep 27, 2022
1361b54
Remove Inferencer multiprocessing: update tests
vblagoje Sep 27, 2022
907bce7
Add more deprecated notes in pydoc
vblagoje Oct 4, 2022
f0850b7
Remove _create_datasets_chunkwise
vblagoje Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove _create_datasets_chunkwise
  • Loading branch information
@vblagoje
vblagoje committed Oct 4, 2022
commit f0850b765bb3f19e89731c0b6815136e6928cc87
12 changes: 0 additions & 12 deletions haystack/modeling/infer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,18 +341,6 @@ def _inference_without_multiprocessing(self, dicts: List[Dict], return_json: boo

return preds_all

@classmethod
def _create_datasets_chunkwise(cls, chunk, processor: Processor):
"""Convert ONE chunk of data (i.e. dictionaries) into ONE pytorch dataset.
This is usually executed in one of many parallel processes.
The resulting datasets of the processes are merged together afterwards"""
dicts = [d[1] for d in chunk]
indices = [d[0] for d in chunk]
dataset, tensor_names, problematic_sample_ids, baskets = processor.dataset_from_dicts(
dicts, indices, return_baskets=True
)
return dataset, tensor_names, problematic_sample_ids, baskets

def _get_predictions(self, dataset: Dataset, tensor_names: List, baskets):
"""
Feed a preprocessed dataset to the model and get the actual predictions (forward pass + formatting).
Expand Down