Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: sync Haystack API with Readme #3223

Merged
merged 33 commits into from
Sep 21, 2022
Merged

docs: sync Haystack API with Readme #3223

merged 33 commits into from
Sep 21, 2022

Conversation

brandenchan
Copy link
Contributor

Proposed Changes:

  • Adds headers to the the created API markdown files so that they can be synced to Readme

How did you test it?

  • Manually tested this

@brandenchan brandenchan requested a review from a team as a code owner September 15, 2022 13:56
@brandenchan brandenchan requested review from ZanSara and removed request for a team September 15, 2022 13:56
@brandenchan brandenchan requested a review from a team as a code owner September 15, 2022 14:11
@masci masci requested review from masci and removed request for ZanSara September 19, 2022 09:04
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a first pass

document_store.md Outdated Show resolved Hide resolved
.github/workflows/readme_integration.yml Outdated Show resolved Hide resolved
@brandenchan
Copy link
Contributor Author

I found that without an accurate "--version" tag in the workflow, the Readme sync will add a copy of an API file instead of overwriting the existing API doc

@brandenchan brandenchan changed the title Sync Haystack API with Readme docs: sync Haystack API with Readme Sep 21, 2022
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment otherwise LGTM!

.github/workflows/readme_integration.yml Outdated Show resolved Hide resolved
@brandenchan brandenchan merged commit 492a804 into main Sep 21, 2022
@brandenchan brandenchan deleted the readme_integration_api branch September 21, 2022 15:18
brandenchan added a commit that referenced this pull request Sep 21, 2022
* First pass at syncing Haystack API with Readme

* Reapply changes

* Regularize slugs

* Regularize slugs

* Regularize slugs

* Set category id and regen

* Trigger workflow

* Delete old md files

* Test sync

* Undo test string

* Incorporate reviewer feedback

* Test on the fly API generation and sync

* Test on the fly API generation and sync

* Test on the fly API generation and sync

* Test on the fly API generation and sync

* Test on the fly API generation and sync

* Change name of pydoc-markdown scripts

* Test on the fly API generation and sync

* Remove version tag

* Test version tag

* Test version tag

* Test version tag

* Revert test docstring

* Revert md file changes

* Revert md file changes

* Revert script naming

* Test on the fly generation and sync

* Adjust for on the fly generation and sync

* Revert test string

* Remove old documentation workflow

* Set workflow to work on main

* Change readme version name
masci pushed a commit that referenced this pull request Sep 22, 2022
* First pass at syncing Haystack API with Readme

* Reapply changes

* Regularize slugs

* Regularize slugs

* Regularize slugs

* Set category id and regen

* Trigger workflow

* Delete old md files

* Test sync

* Undo test string

* Incorporate reviewer feedback

* Test on the fly API generation and sync

* Test on the fly API generation and sync

* Test on the fly API generation and sync

* Test on the fly API generation and sync

* Test on the fly API generation and sync

* Change name of pydoc-markdown scripts

* Test on the fly API generation and sync

* Remove version tag

* Test version tag

* Test version tag

* Test version tag

* Revert test docstring

* Revert md file changes

* Revert md file changes

* Revert script naming

* Test on the fly generation and sync

* Adjust for on the fly generation and sync

* Revert test string

* Remove old documentation workflow

* Set workflow to work on main

* Change readme version name
@masci masci mentioned this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants