test: update filtering of Pinecone mock to imitate doc store #3020
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
1. Filtering
The previous part-Pinecone part-SQL PineconeDocumentStore used the SQL db for many filtering tasks. With the update to a pure-Pinecone document store in #2749 this is no longer the case.
That means that during tests, filtering in the new PineconeDocumentStore relies solely on the filtering in the Pinecone mock instance. Unfortunately, this didn't work for more complex filters. This PR includes a new filtering function to handle these more complex filters.
2.
update
methodAnother need stemming from the pure-Pinecone document store is the need to handle labels without SQL. Part of the implementation for this includes the use of Pinecone's
update
method, which was not originally included in the mock. It has been added here.How did you test it?
Manual verification, unit tests
Notes for the reviewer
N/A
Checklist