Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update File Classifier Docstring #3018

Merged
merged 5 commits into from
Aug 15, 2022
Merged

docs: update File Classifier Docstring #3018

merged 5 commits into from
Aug 15, 2022

Conversation

brandenchan
Copy link
Contributor

Related Issues

Proposed Changes:

  • Change docstring to reflect the fact that there is now no limit on outgoing edges in BaseComponent.

How did you test it?

  • Markdown file generated

@brandenchan brandenchan requested a review from a team as a code owner August 10, 2022 12:29
@brandenchan brandenchan requested a review from a team as a code owner August 10, 2022 12:37
@brandenchan brandenchan changed the title Update File Classifier Docstring WIP: Update File Classifier Docstring Aug 10, 2022
@brandenchan brandenchan changed the title WIP: Update File Classifier Docstring Update File Classifier Docstring Aug 10, 2022
agnieszka-m
agnieszka-m requested changes Aug 10, 2022
View reviewed changes
haystack/nodes/file_classifier/file_type.py Outdated Show resolved Hide resolved
haystack/nodes/file_classifier/file_type.py Outdated Show resolved Hide resolved
@tstadel tstadel added the type:documentation Improvements on the docs label Aug 11, 2022
@ZanSara ZanSara changed the title Update File Classifier Docstring docs: update File Classifier Docstring Aug 11, 2022
tstadel
tstadel approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@tstadel tstadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tstadel tstadel merged commit ff38a20 into master Aug 15, 2022
@tstadel tstadel deleted the file_type_class_docstring branch August 15, 2022 10:37
@ZanSara ZanSara removed their request for review September 1, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara left review comments

@tstadel tstadel tstadel approved these changes

@agnieszka-m agnieszka-m agnieszka-m approved these changes

Assignees
No one assigned
Labels
type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brandenchan @ZanSara @tstadel @agnieszka-m