-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: extend tutorial14 about query classification #3013
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@agnieszka-m, looping you in here as I think you'd like to have a look at the language. @anakin87 I'll also put in a review 🙂 |
Overall I think this is great. I would have one suggestion though, as it's a tutorial, I think it might be useful to be a bit more explicit about the difference of zero-shot vs custom classification. The reader might not understand the difference in the current version. For example it starts off with how for custom, you can use a model from the hub. But then you see that you can also use one for zero-shot. The other thing is they might not understand the difference of you defining your own labels like 'cinema' and 'music' being any different to the other labels which are simply 'label1' etc. All in all some more hand holding go well for a tutorial 👍🏽 Thank you for the contribution!! 🎉 |
Hi! Since my changes are mostly minor language corrections, would you like me to do them directly on your files or would you rather I add comments to the files? Whatever works best for you. |
@TuanaCelik I made some improvements. Please let me know WDYT... 😃
@agnieszka-m for me it is the same... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added my two cents.
Co-authored-by: Agnieszka Marzec <[email protected]>
When the notebook tutorial is acceptable, I will add the .py version as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it very much, nice examples.
Btw, we're planning to make zero-shot query classification one of the highlights of our next release (probably monday). So it would be awesome to have this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @anakin87
Co-authored-by: Agnieszka Marzec <[email protected]>
I've made some minor fixes and added the .py tutorial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor lg corrections
Co-authored-by: Agnieszka Marzec <[email protected]>
Co-authored-by: Agnieszka Marzec <[email protected]>
Co-authored-by: Agnieszka Marzec <[email protected]>
Co-authored-by: Agnieszka Marzec <[email protected]>
@anakin87 this is almost good to go. Only the tutorial script is missing. I'm pushing it over the finish line. |
@anakin87 unfortunately I don't have write access. Can you run the script yourself or grant me access? |
'Allow edits and access to secrets by maintainers' is already selected. What can I do to allow you? |
@anakin87 Ok, weird. To fix this quickly, can you grant me access individually maybe? |
I invited you to collaborate on my fork... Hope it helps... |
@anakin87 Yes thanks! Now it's working. |
As stated in #2965, it would be good to include in Tutorial 14 a small section about new features of
TransformersQueryClassifier
:Proposed Changes:
I added a small section on these features, similar to what has been done for the features already present.
I'm not that good with documentation, so I'd beg the people involved (@agnieszka-m @TuanaCelik @mkkuemmel) to brutally make the necessary changes 😃
Checklist