Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no_answer option to results #24

Merged
merged 6 commits into from
Feb 19, 2020
Merged

Add no_answer option to results #24

merged 6 commits into from
Feb 19, 2020

Conversation

tholor
Copy link
Member

@tholor tholor commented Feb 17, 2020

So far we applied the n_ans_threshold on FARM side, but then dropped all no_answer results in the final aggregation step across all candidate paragraphs (in haystack):

We should add it to the results. There are a few different options how to go with this, but I would suggest:

  • Take the no_answer candidate from the paragraph with the best "real answer" (as both are really competing for the top 1 answer)
  • Use as score: score of no_answer - no_answer_threshold (as no_answer_thresold is kinda boosting the score and this should be reflected in the final results, where we want to sort by score)

Adressing #23

@tholor tholor changed the title Add no_answer option to results WIP Add no_answer option to results Feb 17, 2020
@Timoeller Timoeller changed the title WIP Add no_answer option to results Add no_answer option to results Feb 19, 2020
@Timoeller Timoeller merged commit 0862e8a into master Feb 19, 2020
@Timoeller Timoeller deleted the no_answer branch February 19, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants