Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DPR for latest transformers version & change init arg gpu -> use_gpu for DPR and EmbeddingRetriever #239

Merged
merged 4 commits into from
Jul 16, 2020
Merged

Refactor DPR for latest transformers version & change init arg gpu -> use_gpu for DPR and EmbeddingRetriever #239

merged 4 commits into from
Jul 16, 2020

Conversation

tholor
Copy link
Member

@tholor tholor commented Jul 16, 2020 •
edited
Loading

  • Add truncation=True in the calls to transformers from Dense Passage Retriever to avoid new warnings in transformers 3.0.2
  • Change arg gpu -> use_gpu in init of DPR and EmbeddingRetriever to be more compliant with Readers

Fixing #237

@tholor tholor requested a review from tanaysoni July 16, 2020 07:18
@tholor tholor mentioned this pull request Jul 16, 2020
Closed
@tholor tholor merged commit 6bed2f5 into master Jul 16, 2020
@julian-risch julian-risch deleted the fix_tokenizer_warning branch November 15, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanaysoni tanaysoni tanaysoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tholor @tanaysoni