-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Linux CI to push changes to forks #2182
Conversation
Summary of the solution I've found:
We could implement a "Verify Code & Documentation Updates" action on our end which does not try to commit back the changes, but will always fail if it triggers: that's good because on our end such action would trigger only if the the contributor has not run the corresponding action on their end. @julian-risch I am in the process of implementing the last "verification" action, feel free to start reviewing before and let me know if you see something that needs change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far. Just add a brief description to the contributor guidelines: https://github.com/deepset-ai/haystack/blob/master/CONTRIBUTING.md please. Maybe even with a screenshot of what the contributor needs to do to run the GitHub action?
Let's test the process ourselves with an account that is not in the deepset GitHub organization yet (once your changes are merged).
Right now, the documentation and code style bot will fail on forks as the checkout@v2 action fails. This leads to the situation in which no code style or documentation will be updated on the PR and neither on merge to master (the bot can't push to master right now), but they will trigger on the first PR opened from the updated master.
This PR tries to make checkout@v2 push changes back to the source fork, if possible.