Align REST API and Haystack versions #2164
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Just a small change you should please do before merging: the tutorial 6 changes from #2148 made it in here. We shouldn't do that. Could you please remove them?
| { |
There was a problem hiding this comment.
Just as a warning. Watch out when merging this PR with your other changes of openapi.json in other open PRs.
There was a problem hiding this comment.
I'll manually check if anybody has merge conflicts, hopefully there won't be many
| "info": { | ||
| "title": "Haystack REST API", | ||
| "version": "1.1.0" |
There was a problem hiding this comment.
Would be nice to automate updating this when we make a new release. For now a left a comment in Notion about manually updating it.
There was a problem hiding this comment.
It's actually automated! 😁 Check line 21 of rest_api/application.py
docs/_src/tutorials/tutorials/6.md
Outdated
| @@ -116,13 +116,13 @@ See [their docs](https://milvus.io/docs/v1.0.0/milvus_docker-cpu.md) for more de | |||
|
|
|||
|
|
|||
| ```python | |||
| !pip install git+https://github.com/deepset-ai/haystack.git#egg=farm-haystack[milvus] | |||
There was a problem hiding this comment.
The tutorial 6 changes from #2148 made it in here. We shouldn't do that. Could you please remove them?
| @@ -384,11 +384,11 @@ | |||
| "source": [ | |||
| "# !pip install git+https://github.com/deepset-ai/haystack.git#egg=farm-haystack[milvus]\n", | |||
| "\n", | |||
| "#from haystack.utils import launch_milvus\n", | |||
| "#from haystack.document_stores import MilvusDocumentStore\n", | |||
| "# from haystack.utils import launch_milvus\n", | |||
There was a problem hiding this comment.
The tutorial 6 changes from #2148 made it in here. We shouldn't do that. Could you please remove them?
The version for the REST API FastAPI application was hardcoded to 1.0.0. Here The version number is now aligned with Haystack's.