Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI build-cache issue causing code changes to take no effect #2082

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented Jan 27, 2022

Currently if the build-cache is hit, code changes take no effect:

  • without editable mode, a wheel file for haystack is created and it is installed into the python env site-packages (farm_haystack-1.1.0.dist-info) linking to the haystack location. Although there is no code installed, changes of the next commit take no effect, probably due to the interplay of python caching and build chaching.
  • with editable mode there is only a farm-haystack.egg-link created in the python env pointing to the haystack location

Proposed changes:

  • install haystack in editable mode in CI scripts

@tstadel tstadel requested a review from ZanSara January 27, 2022 23:15
@tstadel tstadel changed the title Fix CI build-cache issue that code changes take no effect Fix CI build-cache issue causing code changes to take no effect Jan 27, 2022
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one, thank you!

@ZanSara ZanSara merged commit 1b1e44e into master Jan 28, 2022
@ZanSara ZanSara deleted the fix_ci_python_cache branch January 28, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants