Enable batch mode for SAS cross encoders #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-risch
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
These changes look good to me. 👍 I had to think a moment to understand the difference in the two lines:
top_1_sas.append(np.max(scores_window[:len_l]))
top_k_sas.append(np.max(scores_window))
Maybe a comment could have explained here that we consider the best score out of len_l labels for the top prediction for the first line of code, etc. and for the second line the best score out of multiple predictions. However, I'd be fine with merging it as is.
| @@ -405,6 +405,8 @@ def semantic_answer_similarity(predictions: List[List[str]], | |||
| current_position = 0 | |||
| for len_p, len_l in lengths: | |||
| scores_window = scores[current_position:current_position+len_p*len_l] | |||
| # Per predicted doc there are len_l entries comparing it to all len_l labels. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
closes #1769