Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify vector_dim and embedding_dim parameter in Document Store #1922

Merged
merged 6 commits into from
Jan 10, 2022
Merged

Unify vector_dim and embedding_dim parameter in Document Store #1922

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bb2a839
Refactored code to unify vector_dim and embedding_dim parameter in Do…
mathew55 Dec 23, 2021
5c058b2
Unit test cases updated to use `embedding_dim` instead of `vector_dim`
mathew55 Dec 31, 2021
07b69c2
Unit test case update to use embedding_dim instead of vector_dim
mathew55 Jan 9, 2022
461ca73
Merge branch 'master' into 1740_unify_vector_dim_embedding_dim
mathew55 Jan 9, 2022
5a423ad
Add latest docstring and tutorial changes
github-actions[bot] Jan 9, 2022
10d635d
Put usage of `vector_dim` param in same if-block as corresponding war…
bogdankostic Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into 1740_unify_vector_dim_embedding_dim
  • Loading branch information
@mathew55
mathew55 authored Jan 9, 2022
commit 461ca73911966609b77f262c1812f40f337b47d4
1 change: 0 additions & 1 deletion haystack/document_stores/faiss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ def __init__(
vector_dim=vector_dim,
embedding_dim=embedding_dim,
faiss_index_factory_str=faiss_index_factory_str,
faiss_index=faiss_index,
return_embedding=return_embedding,
duplicate_documents=duplicate_documents,
index=index,
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.