Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove queries param from pipeline.eval() #1836

Merged
merged 2 commits into from
Dec 2, 2021
Merged

remove queries param from pipeline.eval() #1836

merged 2 commits into from
Dec 2, 2021

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented Dec 2, 2021

Proposed changes:

  • get rid of redundant queries param in pipeline.eval()

Each label already contains the query.

julian-risch
julian-risch approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 👍

@tstadel tstadel merged commit dc4cd49 into master Dec 2, 2021
@tstadel tstadel deleted the eval_remove_query_param branch December 2, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

@tholor tholor Awaiting requested review from tholor

Assignees
No one assigned
Labels
topic:pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tstadel @julian-risch @tholor