Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt docker-compose-gpu.yml to use DPR by default #1810

Merged
merged 7 commits into from
Nov 25, 2021

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Nov 25, 2021

Changes:

  • Now both docker-compose files use Julian's countries dataset
  • The GPU version uses DPR as the default pipeline in the REST API
  • The GPU version has the file upload disabled to be ready to deploy as the hosted version (is this OK?)

Note: This assumes that the dataset used already has embeddings for the documents it contains. So do not merge before Julian confirms that the ES image has the embeddings too.

docker-compose-gpu.yml Outdated Show resolved Hide resolved
docker-compose-gpu.yml Outdated Show resolved Hide resolved
docker-compose-gpu.yml Outdated Show resolved Hide resolved
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@ZanSara ZanSara merged commit 1a4ee21 into master Nov 25, 2021
@ZanSara ZanSara deleted the configure_pipeline_file_env_var branch November 25, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants