Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the Random Question functionality #1808

Merged
merged 4 commits into from
Nov 24, 2021
Merged

Improve the Random Question functionality #1808

merged 4 commits into from
Nov 24, 2021

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Nov 24, 2021 •
edited
Loading

and add three example questions related to the countries dataset.

Current UI:

image

@ZanSara ZanSara requested a review from tholor November 24, 2021 13:33
tholor
tholor approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me.
Once we validated performance on the new dataset we should also switch the DEFAULT_QUESTION that shows up at startup + change the docker-compose image. But let's do this later in a separate PR.

@ZanSara ZanSara merged commit 742d4b9 into master Nov 24, 2021
@ZanSara ZanSara deleted the demo-ui-random-questions branch November 24, 2021 14:55
@tholor tholor added the topic:ui label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZanSara @tholor