Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rest api in Docker image after refactoring #178

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Fix rest api in Docker image after refactoring #178

merged 1 commit into from
Jun 26, 2020

Conversation

guillim
Copy link
Contributor

@guillim guillim commented Jun 26, 2020

I am not sure, but reading your codebase I have the feeling that you did some code refactoring recently. Here is a proposal to reflect that

I am not sure, but reading your codebase I have the feeling that you did some code refactoring recently. Here is a proposal to reflect that
@tholor
Copy link
Member

tholor commented Jun 26, 2020

Yes, absolutely. Thanks for flagging & fixing this @guillim !
The rest API was moved out of the package in #160, but the Dockerfile was not adjusted accordingly.

@tholor tholor requested a review from tanaysoni June 26, 2020 15:26
@tholor tholor changed the title Some proposal to reflect your code refacto Fix rest api in Docker image after refactoring Jun 26, 2020
@tholor tholor merged commit 27b8c98 into deepset-ai:master Jun 26, 2020
@guillim guillim deleted the patch-2 branch June 26, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants