Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate old pipeline eval nodes: EvalDocuments and EvalAnswers #1778

Merged
merged 3 commits into from
Dec 2, 2021

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented Nov 19, 2021

Proposed changes:

  • log warning in EvalDocuments and EvalAnswers constructors
  • add warning to docstrings

Warning will be like:

WARNING - haystack.nodes.evaluator.evaluator -  EvalDocuments node is deprecated and will be removed in a future version. Please use pipeline.eval() instead.
WARNING - haystack.nodes.evaluator.evaluator -  EvalAnswers node is deprecated and will be removed in a future version. Please use pipeline.eval() instead.

Status:

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

closes #1717

must not be merged before #1760

@tstadel tstadel marked this pull request as ready for review December 2, 2021 15:50
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate old pipeline eval nodes: EvalDocuments and EvalAnswers
3 participants