Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed delete_all_documents to delete_documents in Tutorial5 #1477

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

ju-gu
Copy link
Member

@ju-gu ju-gu commented Sep 19, 2021

Proposed changes:

  • Changed delete_all_documents to delete_documents in Tutorial5 as delete_all_documents has a deprecated warning

Status (please check what you already did):

  • [ x] First draft (up for discussions & feedback)
  • [ x] Final code
  • Added tests
  • Updated documentation

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Congrats to your first pull request in haystack! 👍

@julian-risch julian-risch merged commit 05da7f7 into deepset-ai:master Sep 20, 2021
@tholor tholor added topic:ui type:documentation Improvements on the docs and removed topic:ui labels Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants