Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Finder from tutorials #1329

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Remove Finder from tutorials #1329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove Finder from tutorials
  • Loading branch information
@tholor
tholor committed Aug 10, 2021
commit d47bd447add307ab092eb6797fbb307fee565c38
13 changes: 2 additions & 11 deletions tutorials/Tutorial1_Basic_QA_Pipeline.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@
"# 'meta': {'name': \"<DOCUMENT_NAME_HERE>\", ...}\n",
"#}\n",
"# (Optionally: you can also add more key-value-pairs here, that will be indexed as fields in Elasticsearch and\n",
"# can be accessed later for filtering or shown in the responses of the Finder)\n",
"# can be accessed later for filtering or shown in the responses of the Pipeline)\n",
"\n",
"# Let's have a look at the first 3 entries:\n",
"print(dicts[:3])\n",
Expand All @@ -241,7 +241,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"## Initalize Retriever, Reader, & Finder\n",
"## Initalize Retriever, Reader, & Pipeline\n",
"\n",
"### Retriever\n",
"\n",
Expand Down Expand Up @@ -512,15 +512,6 @@
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.7.6"
},
"pycharm": {
"stem_cell": {
"cell_type": "raw",
"source": [],
"metadata": {
"collapsed": false
}
}
}
},
"nbformat": 4,
Expand Down
12 changes: 1 addition & 11 deletions tutorials/Tutorial3_Basic_QA_Pipeline_without_Elasticsearch.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@
},
"outputs": [],
"source": [
"from haystack import Finder\n",
"from haystack.preprocessor.cleaning import clean_wiki_text\n",
"from haystack.preprocessor.utils import convert_files_to_dicts, fetch_archive_from_http\n",
"from haystack.reader.farm import FARMReader\n",
Expand Down Expand Up @@ -169,7 +168,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"## Initalize Retriever, Reader, & Finder\n",
"## Initalize Retriever, Reader & Pipeline\n",
"\n",
"### Retriever\n",
"\n",
Expand Down Expand Up @@ -443,15 +442,6 @@
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.7.6"
},
"pycharm": {
"stem_cell": {
"cell_type": "raw",
"source": [],
"metadata": {
"collapsed": false
}
}
}
},
"nbformat": 4,
Expand Down
3 changes: 1 addition & 2 deletions tutorials/Tutorial3_Basic_QA_Pipeline_without_Elasticsearch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#
# If you are interested in more feature-rich Elasticsearch, then please refer to the Tutorial 1.

from haystack import Finder
from haystack.document_store.memory import InMemoryDocumentStore
from haystack.document_store.sql import SQLDocumentStore
from haystack.preprocessor.cleaning import clean_wiki_text
Expand Down Expand Up @@ -50,7 +49,7 @@ def tutorial3_basic_qa_pipeline_without_elasticsearch():
document_store.write_documents(dicts)


# ## Initalize Retriever, Reader, & Finder
# ## Initalize Retriever, Reader & Pipeline
#
# ### Retriever
#
Expand Down
10 changes: 0 additions & 10 deletions tutorials/Tutorial4_FAQ_style_QA.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@
},
"outputs": [],
"source": [
"from haystack import Finder\n",
"from haystack.document_store.elasticsearch import ElasticsearchDocumentStore\n",
"\n",
"from haystack.retriever.dense import EmbeddingRetriever\n",
Expand Down Expand Up @@ -317,15 +316,6 @@
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.7.6"
},
"pycharm": {
"stem_cell": {
"cell_type": "raw",
"source": [],
"metadata": {
"collapsed": false
}
}
}
},
"nbformat": 4,
Expand Down
1 change: 0 additions & 1 deletion tutorials/Tutorial4_FAQ_style_QA.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from haystack import Finder
from haystack.document_store.elasticsearch import ElasticsearchDocumentStore

from haystack.retriever.dense import EmbeddingRetriever
Expand Down
3 changes: 1 addition & 2 deletions tutorials/Tutorial6_Better_Retrieval_via_DPR.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,6 @@
},
"outputs": [],
"source": [
"from haystack import Finder\n",
"from haystack.preprocessor.cleaning import clean_wiki_text\n",
"from haystack.preprocessor.utils import convert_files_to_dicts, fetch_archive_from_http\n",
"from haystack.reader.farm import FARMReader\n",
Expand Down Expand Up @@ -452,7 +451,7 @@
"id": "wgjedxx_A6N6"
},
"source": [
"### Initalize Retriever, Reader, & Finder\n",
"### Initalize Retriever, Reader & Pipeline\n",
"\n",
"#### Retriever\n",
"\n",
Expand Down
1 change: 0 additions & 1 deletion tutorials/Tutorial6_Better_Retrieval_via_DPR.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from haystack import Finder
from haystack.document_store import FAISSDocumentStore, MilvusDocumentStore
from haystack.preprocessor.cleaning import clean_wiki_text
from haystack.preprocessor.utils import convert_files_to_dicts, fetch_archive_from_http
Expand Down