Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SQLAlchemy relationship warnings #1289

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Fix SQLAlchemy relationship warnings #1289

merged 1 commit into from
Jul 15, 2021

Conversation

oryx1729
Copy link
Contributor

@oryx1729 oryx1729 commented Jul 15, 2021 •
edited
Loading

In SQLAlchemy relationships, backref creates bi-directional relationships automagically which is not needed in this case as both DocumentORM and MetaORM have "explicit" defined relationships.

This PR replaces backref with back_populates and that removes the SQLAlchemy warnings as described here.

@oryx1729 oryx1729 requested a review from tholor July 15, 2021 14:47
@oryx1729 oryx1729 changed the title Fix SQLAlchemy warnings Fix SQLAlchemy realtionship warnings Jul 15, 2021
@oryx1729 oryx1729 changed the title Fix SQLAlchemy realtionship warnings Fix SQLAlchemy relationship warnings Jul 15, 2021
tholor
tholor approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oryx1729 oryx1729 merged commit 3f58d4c into master Jul 15, 2021
@oryx1729 oryx1729 deleted the fix-orm-relationships branch July 15, 2021 16:00
@oryx1729 oryx1729 mentioned this pull request Jul 16, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oryx1729 @tholor