Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize crawler output to JSON #1284

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Serialize crawler output to JSON #1284

merged 1 commit into from
Jul 14, 2021

Conversation

oryx1729
Copy link
Contributor

Resolves #1197

@oryx1729 oryx1729 self-assigned this Jul 14, 2021
@oryx1729 oryx1729 requested a review from tholor July 14, 2021 09:22
tholor
tholor approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oryx1729 oryx1729 merged commit c318b58 into master Jul 14, 2021
@oryx1729 oryx1729 deleted the fix-crawler-output branch July 14, 2021 11:16
@oryx1729 oryx1729 mentioned this pull request Jul 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees

@oryx1729 oryx1729

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crawler does not write JSON, but serializes the result dict to a string written in a .json file
2 participants
@oryx1729 @tholor