Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add methods to remove and replace components in a pipeline #7820

Merged
merged 8 commits into from
Jun 10, 2024
Merged

feat: add methods to remove and replace components in a pipeline #7820

merged 8 commits into from
Jun 10, 2024

Conversation

CarlosFerLo
Copy link
Contributor

Related Issues

Proposed Changes:

Add a 'remove_component' method to 'PipelineBase' that safely removes edges from the pipeline, as suggested.

How did you test it?

Added two unit tests to ensure correct behaviour.

Notes for the reviewer

Waiting for instructions on how to proceed with the replace method, as I do not know how you want it to work.

Checklist

  • I have read the contributors guidelines and the code of conduct ✅
  • I have updated the related issue with new insights and changes ✅
  • I added unit tests and updated the docstrings ✅
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:. ✅
  • I documented my code ✅
  • I ran pre-commit hooks and fixed any issue ✅

@CarlosFerLo CarlosFerLo requested review from a team as code owners June 6, 2024 17:36
@CarlosFerLo CarlosFerLo requested review from dfokina and anakin87 and removed request for a team June 6, 2024 17:36
@CarlosFerLo CarlosFerLo mentioned this pull request Jun 6, 2024
Closed
@coveralls
Copy link
Collaborator

coveralls commented Jun 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9405373210

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 89.697%
Files with Coverage Reduction New Missed Lines %
core/pipeline/base.py 17 92.88%
Totals Coverage Status
Change from base Build 9402214223: 0.005%
Covered Lines: 6782
Relevant Lines: 7561
💛 - Coveralls

@anakin87 anakin87 requested a review from shadeMe June 6, 2024 20:35
shadeMe
shadeMe previously requested changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! One minor change.

haystack/core/pipeline/base.py Outdated Show resolved Hide resolved
@anakin87 anakin87 removed their request for review June 7, 2024 11:04
@coveralls
Copy link
Collaborator

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9415946865

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 89.758%
Files with Coverage Reduction New Missed Lines %
components/evaluators/llm_evaluator.py 2 95.5%
core/pipeline/base.py 17 92.88%
Totals Coverage Status
Change from base Build 9402214223: 0.07%
Covered Lines: 6827
Relevant Lines: 7606
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9416311047

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 89.788%
Files with Coverage Reduction New Missed Lines %
components/evaluators/llm_evaluator.py 2 95.5%
core/pipeline/base.py 15 93.59%
Totals Coverage Status
Change from base Build 9402214223: 0.1%
Covered Lines: 6832
Relevant Lines: 7609
💛 - Coveralls

@shadeMe shadeMe requested review from shadeMe and removed request for shadeMe June 7, 2024 12:26
@coveralls
Copy link
Collaborator

coveralls commented Jun 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9446028177

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 89.788%
Files with Coverage Reduction New Missed Lines %
core/pipeline/base.py 15 93.59%
Totals Coverage Status
Change from base Build 9445367736: 0.04%
Covered Lines: 6832
Relevant Lines: 7609
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9448092844

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 89.798%
Files with Coverage Reduction New Missed Lines %
core/pipeline/base.py 14 93.73%
Totals Coverage Status
Change from base Build 9445367736: 0.05%
Covered Lines: 6839
Relevant Lines: 7616
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9448290533

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 89.798%
Files with Coverage Reduction New Missed Lines %
core/pipeline/base.py 14 93.73%
Totals Coverage Status
Change from base Build 9445367736: 0.05%
Covered Lines: 6839
Relevant Lines: 7616
💛 - Coveralls

silvanocerza
silvanocerza approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@silvanocerza silvanocerza merged commit 7fe0244 into deepset-ai:main Jun 10, 2024
22 checks passed
@CarlosFerLo CarlosFerLo deleted the issue-7759 branch June 10, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

@shadeMe shadeMe Awaiting requested review from shadeMe

Assignees

@silvanocerza silvanocerza

Labels
topic:core topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipeline methods to remove and replace added components
4 participants
@CarlosFerLo @coveralls @shadeMe @silvanocerza