Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline methods to remove and replace added components #7759

Closed
shadeMe opened this issue May 29, 2024 · 4 comments · Fixed by #7820
Closed

Pipeline methods to remove and replace added components #7759

shadeMe opened this issue May 29, 2024 · 4 comments · Fixed by #7820
Labels
2.x Related to Haystack v2.0 P2 Medium priority, add to the next sprint if no P1 available topic:pipeline

Comments

@shadeMe
Copy link
Collaborator

shadeMe commented May 29, 2024 •
edited
Loading

We should add a remove_component method to remove components in an existing pipeline. This will also allow for the easy replacement of components.
@shadeMe shadeMe added topic:pipeline P2 Medium priority, add to the next sprint if no P1 available 2.x Related to Haystack v2.0 labels May 29, 2024
@CarlosFerLo
Copy link
Contributor

working on it

@CarlosFerLo CarlosFerLo mentioned this issue Jun 6, 2024
Merged
@CarlosFerLo
Copy link
Contributor

Created a PR #7820 to work on this issue, do not know hoy you intend the replace method to work. Waiting for your response @shadeMe to implement it. Removing components is already done.

@shadeMe
Copy link
Collaborator Author

shadeMe commented Jun 7, 2024

On second thought, the remove_component method would be enough - After removal, one can add the replacement with add_component.

@CarlosFerLo
Copy link
Contributor

perfect, then everything is set to be merged into main in the following days :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 P2 Medium priority, add to the next sprint if no P1 available topic:pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add methods to remove and replace components in a pipeline CarlosFerLo/haystack
2 participants
@shadeMe @CarlosFerLo