-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorial 1 colab #38
Comments
Oh yes, totally! Thanks for reporting. Do you want to create a PR or should I take care of this? |
I think it would be better if you update it. Just to keep the notebook on your drive, I guess |
Fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The parameter names passed to
write_documents_to_db
andTfidfRetriever
in the Colab notebook of Tutorial 1 need to be updated fromdatastore=datastore
todocument_store=document_store
, because they currently produce TypeError.The variable
datastore = SQLDocumentStore(url="sqlite:https:///qa.db")
should also be updated todocument_store = SQLDocumentStore(url="sqlite:https:///qa.db")
for naming consistencyThe text was updated successfully, but these errors were encountered: