Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial 1 colab #38

Closed
M-Salti opened this issue Mar 7, 2020 · 3 comments
Closed

Update tutorial 1 colab #38

M-Salti opened this issue Mar 7, 2020 · 3 comments

Comments

@M-Salti
Copy link

M-Salti commented Mar 7, 2020

The parameter names passed to write_documents_to_db and TfidfRetriever in the Colab notebook of Tutorial 1 need to be updated from datastore=datastore to document_store=document_store, because they currently produce TypeError.

The variable datastore = SQLDocumentStore(url="sqlite:https:///qa.db") should also be updated to document_store = SQLDocumentStore(url="sqlite:https:///qa.db") for naming consistency

@tholor
Copy link
Member

tholor commented Mar 7, 2020

Oh yes, totally! Thanks for reporting. Do you want to create a PR or should I take care of this?

@M-Salti
Copy link
Author

M-Salti commented Mar 7, 2020

I think it would be better if you update it. Just to keep the notebook on your drive, I guess

@tholor
Copy link
Member

tholor commented Mar 7, 2020

Fixed :)

@tholor tholor closed this as completed Mar 7, 2020
masci pushed a commit that referenced this issue Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants