Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First commit for adding the download path to the frontmatter #70

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

TuanaCelik
Copy link
Member

In this PR, I also make it so that the first line of the .ipynb is excluded while generating markdowns. This way we can display it wherever we want on HSH

I've generated the new markdown for tutorial 1 only for now. @masci if you agree this is a good implementation let me know.

@brandenchan tagging you here so that you're aware too. On top of this I'll also create a PR for the 'slugs' that we can also have a look at together

In this PR, I also make it so that the first line of the .ipynb is excluded while generating markdowns. This way we can display it wherever we want on HSH
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation LGTM, we should amend the Hugo template to show .Title before merging this one, correct?

@TuanaCelik
Copy link
Member Author

Implementation LGTM, we should amend the Hugo template to show .Title before merging this one, correct?

Indeed but also I'll generate markdowns for the rest of the tutorials too :)

@TuanaCelik
Copy link
Member Author

@brandenchan - This is the PR that adds the 'download' button to the tutorials, and also does the 'Title' trick that I explained to you on our call. If you're ok with that, I will update all of the tutorials here and merge. Just checking again that you consent to this experiment so that we can have the button below the title :)

@brandenchan
Copy link
Contributor

@brandenchan - This is the PR that adds the 'download' button to the tutorials, and also does the 'Title' trick that I explained to you on our call. If you're ok with that, I will update all of the tutorials here and merge. Just checking again that you consent to this experiment so that we can have the button below the title :)

Ok go ahead

@TuanaCelik
Copy link
Member Author

Updated the download links to all PRs here. I excluded the 19th as Bilge is fixing the fact that the notebook did not have a title in #74 - @bilgeyucel when this PR is merged you might want to merge it into your PR and generate markdown again. It will remove the first line (so the title) - which HSH will add itself

@bilgeyucel bilgeyucel mentioned this pull request Nov 24, 2022
2 tasks
@TuanaCelik TuanaCelik merged commit ad9267a into main Nov 24, 2022
@TuanaCelik TuanaCelik deleted the download-button-and-skip-h1 branch November 24, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants