Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Replace outdated action #57

Merged
merged 7 commits into from
Oct 31, 2022
Merged

[CI] Replace outdated action #57

merged 7 commits into from
Oct 31, 2022

Conversation

masci
Copy link
Contributor

@masci masci commented Oct 31, 2022

The action we're using is not maintained anymore and is causing deprecation warnings

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@julian-risch julian-risch self-requested a review October 31, 2022 12:15
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Ready to be merged.
The only thing I had to check in more detail and look up was why "fetch-depth" is set in the "Checkout" step but not in the "Get changed files" step. I checked the docs and it's good as it is.

@masci masci merged commit 8228910 into main Oct 31, 2022
@masci masci deleted the massi/fix-action-warnings branch October 31, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants