Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tutorial 6] Use in memory sqlite to allow re-running the tutorial #55

Closed
wants to merge 2 commits into from

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Oct 28, 2022

Problem
Currently, re-running Tutorial 6 several times might make FAISS complain about the fact that the content of its SQLite instance is still populated by leftover metadata from the previous execution. A contributor reported it happening on Colab.

https://discord.com/channels/993534733298450452/1033011959819423834/1035572050175213608

Solution
Specify that FAISS should use an in-memory version of SQLite, so that it will get erased with the FAISS backend when cells are re-run

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ZanSara ZanSara added the bug Something isn't working label Oct 28, 2022
@TuanaCelik
Copy link
Member

LGTM! - Can you generate the .md file and then we should be good to go 👍

@TuanaCelik
Copy link
Member

@ZanSara would you like to revisit this PR now that we've merged a substantial update to tutorial 1?

@bilgeyucel
Copy link
Contributor

The mentioned problem is solved with #248

@bilgeyucel bilgeyucel closed this Nov 6, 2023
@bilgeyucel bilgeyucel deleted the tut6-faiss-fix branch November 6, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants