-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New tutorial: 19_multimodal_retrieval #52
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
We don't have automatic preview set up yet for tutorials in the new website but I've created one for you here. Thought it might be helpful to see how it looks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason why the tutorial itself is not a .ipynb
? By default we (for now) allow people to open the tutorial in colab. So if this is what you also want people to be able to do the tutorial itself should be a .ipynb
file and then the generate_markdown.py
script will generate the displayed markdown for you anyway.
You can see the contributing process here: https://github.com/deepset-ai/haystack-tutorials/blob/main/Contributing.md
@TuanaCelik It is |
ah my mistake, then there's something else weird here. The generated code snippets in the preview link look odd, there's no highlighting. Maybe there's something else that's going on here. Did you generate the |
I generated it using the script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mayankjobanputra, great work! Concise and clear. I especially like the additional queries 😄
I've spotted a couple of typos and phrasing, extended some variable names (i love long variable names 😄). I had to comment on the .md
because the .ipynb
doesn't have its cells cleared, so it's huge and hard to parse by a human. Not a big deal though, just move my suggestions there. I think you should clear the cells before merging this one to main
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add an entry in the README.md file?
markdowns/19_Text_to_Image_search_pipeline_with_MultiModal_Retriever.md
Outdated
Show resolved
Hide resolved
markdowns/19_Text_to_Image_search_pipeline_with_MultiModal_Retriever.md
Outdated
Show resolved
Hide resolved
markdowns/19_Text_to_Image_search_pipeline_with_MultiModal_Retriever.md
Outdated
Show resolved
Hide resolved
markdowns/19_Text_to_Image_search_pipeline_with_MultiModal_Retriever.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few smaller comments, but otherwise I give this the thumbs up
markdowns/19_Text_to_Image_search_pipeline_with_MultiModal_Retriever.md
Outdated
Show resolved
Hide resolved
markdowns/19_Text_to_Image_search_pipeline_with_MultiModal_Retriever.md
Outdated
Show resolved
Hide resolved
markdowns/19_Text_to_Image_search_pipeline_with_MultiModal_Retriever.md
Outdated
Show resolved
Hide resolved
markdowns/19_Text_to_Image_search_pipeline_with_MultiModal_Retriever.md
Outdated
Show resolved
Hide resolved
markdowns/19_Text_to_Image_search_pipeline_with_MultiModal_Retriever.md
Outdated
Show resolved
Hide resolved
markdowns/19_Text_to_Image_search_pipeline_with_MultiModal_Retriever.md
Outdated
Show resolved
Hide resolved
markdowns/19_Text_to_Image_search_pipeline_with_MultiModal_Retriever.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor typo and it's good to go as far as I'm concerned :)
A tutorial about the MultiModalRetriever, and built a simple retrieval pipeline that searches relevant images given a text query.