Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add precommit #31

Merged
merged 14 commits into from
Sep 23, 2022
Merged

Add precommit #31

merged 14 commits into from
Sep 23, 2022

Conversation

anakin87
Copy link
Member

Successor of #4, after the repo visibility has changed.

@anakin87
Copy link
Member Author

This doesn't seem to work on macOS, filepath is relative to the root of the repo while notebook_tutorials_dir is absolute.

I had the same problem in Haystack, I think we can hardcode paths here and use relatives everywhere.

@masci In this case I made a first attempt to make pathlib work with absolute paths...
Could you try it in macOS?

@anakin87 anakin87 requested a review from masci September 22, 2022 15:41
masci
masci approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

@masci masci merged commit 46c61b6 into deepset-ai:main Sep 23, 2022
@anakin87 anakin87 deleted the add_precommit branch September 23, 2022 14:30
@masci masci mentioned this pull request Sep 26, 2022
Closed
This was referenced Oct 12, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anakin87 @masci