Introduce testing #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Looks good to me. As I can see this PR doesn't only include Tutorial 1 refactors as an example but it will also only attempt to run tutorial 1. Happy to merge if that's the case and I'm not missing anything.. |
|
@TuanaCelik yes, tutorial 01 is executed both on PRs touching it and nightlies |
TuanaCelik
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces notebooks testing, very close to what we have in Haystack:
As we decided to stop supporting the pure Python version of the tutorials, the testing strategy consists of two steps:
nbconvertThe conversion drops any cell containing shell scripts, in order to avoid errors in the CI. To be able to do this, the notebooks need a bit of refactoring, grouping all the shell script code in dedicated cells - this has already been done in this PR for Tutorial 01 as an example. The rest of the tutorials will be adapted in subsequent PRs.