Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tutorial 14 testable #19

Merged
merged 4 commits into from
Dec 16, 2022
Merged

make tutorial 14 testable #19

merged 4 commits into from
Dec 16, 2022

Conversation

masci
Copy link
Contributor

@masci masci commented Sep 16, 2022

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@masci
Copy link
Contributor Author

masci commented Dec 1, 2022

blocked on deepset-ai/haystack#2904

Copy link
Member

@TuanaCelik TuanaCelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would you like to do the honors and let's see how the test goes @masci ?

@masci masci merged commit 9b71be9 into main Dec 16, 2022
@masci masci deleted the massi/14 branch December 16, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants