Add lancedb-haystack to integrations. #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilgeyucel
reviewed
Jun 3, 2024
There was a problem hiding this comment.
Thanks for the PR @alanmeeson. I left one minor comment. Also feel free to add a logo that will be displayed on a dark background 😊
|
I've updated the pip install block to be tagged as shell, got in touch with the LanceDB team and sourced the official 'light on dark' logo, and added a link to the new API docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the LanceDB Haystack Document Store from https://github.com/alanmeeson/lancedb-haystack.
Notes from Discord discussion:
There are some interesting quirks due to the nature of LanceDB; you need to specify a schema for your metadata so that it can be turned into a pyarrow struct (and thus be searchable). Also the precision of the embedding vectors seems to be limited to an error of around 10^-7 compared to it's python form - feels like some sort of difference between the float representations.
Please take a look when you have time, and let me know if I should change anything.
Thanks!