-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
update milvus readme with milvus lite #232
base: main
Are you sure you want to change the base?
Conversation
Hello @bilgeyucel , here is a synchronize with our new milvus-haystack change, which introduct the new feature of milvus-lite which is about to be released. Could you please help to review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zc277584121, I left one minor comment
``` | ||
|
||
### Usage | ||
|
||
First, to start up a Milvus service, follow the ['Start Milvus'](https://milvus.io/docs/install_standalone-docker.md#Start-Milvus) instructions in the documentation. | ||
By default, if you install the latest version of pymilvus, you don't need to start the milvus service manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give information about the latest version number here? Is it 2.4+?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is , 2.4+ is ok, 2.4.3+ is more stable
Signed-off-by: ChengZi <[email protected]>
I have updated the description, which I think is a better expression. @bilgeyucel could you please help to review it |
```python | ||
from haystack import Document | ||
from milvus_haystack import MilvusDocumentStore | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running into this code, there's a dependency error:
ContextualVersionConflict Traceback (most recent call last)
[<ipython-input-2-678eb02a0f80>](https://localhost:8080/#) in <cell line: 2>()
1 from haystack import Document
----> 2 from milvus_haystack import MilvusDocumentStore
3
4 document_store = MilvusDocumentStore(
5 connection_args={"uri": "./milvus.db"}, # Milvus Lite
8 frames
[/usr/local/lib/python3.10/dist-packages/pkg_resources/__init__.py](https://localhost:8080/#) in _resolve_dist(self, req, best, replace_conflicting, env, installer, required_by, to_activate)
871 # Oops, the "best" so far conflicts with a dependency
872 dependent_req = required_by[req]
--> 873 raise VersionConflict(dist, req).with_context(dependent_req)
874 return dist
875
ContextualVersionConflict: (grpcio 1.64.0 (/usr/local/lib/python3.10/dist-packages), Requirement.parse('grpcio<=1.63.0,>=1.49.1'), {'pymilvus'})
@zc277584121 any ideas on how to resolve? This was in a Colab, in a clean Python environment where I ran only the pip commands suggested in this documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Colab, after running the pip command, we have to restart the session kernel to make the grpcio dependency really installed. I think it is a problem in Colab, where the default environment is not clean but exist an installed grpcio. And after pip install pymilvus[->grpcio], actually it is not be install and can not work normally. and we have to restart the colab kernel to make the pip install xxx
really be installed and work normally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here is our official document: https://milvus.io/docs/integrate_with_haystack.md , where we mind users to restart kernel in colab
No description provided.