Add NVIDIA integration tile #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annthurium
requested review from
silvanocerza,
shadeMe,
TuanaCelik and
bilgeyucel
bilgeyucel
reviewed
Mar 12, 2024
Co-authored-by: Silvano Cerza <[email protected]>
Co-authored-by: Silvano Cerza <[email protected]>
|
FYI: Let's not merge this PR until later this week - We'll be updating the integration to support a new Nvidia service, which will change the API a bit. Once those changes have been merged into core integrations, we'll update the code snippets above and sign off this PR's merging. |
Co-authored-by: Bilge Yücel <[email protected]>
|
@shadeMe works for me as long as we have some sort of page up by next Monday when I head to GTC. |
shadeMe
reviewed
Mar 19, 2024
|
@annthurium @shadeMe Should we be merging this now? What's the situation? |
shadeMe
approved these changes
Apr 9, 2024
TuanaCelik
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.