Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mixedbread ai integration #152

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Conversation

juliuslipp
Copy link
Contributor

@juliuslipp juliuslipp commented Jan 27, 2024

Hey guys,

I just created a mixedbread ai integration. Would be lovely, if you could add it.

cheers,
Julius

@TuanaCelik TuanaCelik self-requested a review January 31, 2024 13:38
@TuanaCelik TuanaCelik self-assigned this Jan 31, 2024
Copy link
Member

@TuanaCelik TuanaCelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution 🚀 I've made some small edits mainly to conform with the structure we would like to stick to.
I don't know if you have it, but some integrations have their own generated API docs, I see you have quite good docstrings in the repo so if you have the API docs somewhere, let's please add a link to those in this page too 🙏

Additionally, if you have an example colab, feel free to add that here and to the cookbook repo: https://github.com/deepset-ai/haystack-cookbook

integrations/mixedbread-ai.md Outdated Show resolved Hide resolved
integrations/mixedbread-ai.md Outdated Show resolved Hide resolved
integrations/mixedbread-ai.md Outdated Show resolved Hide resolved
integrations/mixedbread-ai.md Outdated Show resolved Hide resolved
@juliuslipp
Copy link
Contributor Author

juliuslipp commented Jan 31, 2024

Thank you @TuanaCelik! I added a query example as well and modified the description a little bit, and the package name ("-" instead of "_").

Copy link
Member

@TuanaCelik TuanaCelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @juliuslipp I think we're ready to merge this. But I was trying to use the component just before merging. I'm unable to create an API key on the mixedbread dashboard just yet, I seem to get an error. Once I'm able to do this and test it I'll merge.

PS: I'll probably create a PR for your readme too :)

@juliuslipp
Copy link
Contributor Author

Hey @TuanaCelik, thanks for letting us know. I rolled back the frontend, you should be able to create api-keys now. (There's some random issues with a minor version update for react-query, investigating now):

@TuanaCelik TuanaCelik self-requested a review February 1, 2024 15:39
Copy link
Member

@TuanaCelik TuanaCelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, tested it and all works smoothly, thank you for the contribution.

Some asks:

  1. If you have an example colab, please consider adding it to the haystack cookbook and linking it from this page 🙏
  2. If you can, could you please write a readme for your own repo? If not, I'll come back to it later and make a pr

@TuanaCelik TuanaCelik merged commit 360d012 into deepset-ai:main Feb 1, 2024
@juliuslipp
Copy link
Contributor Author

Great, tested it and all works smoothly, thank you for the contribution.

Some asks:

  1. If you have an example colab, please consider adding it to the haystack cookbook and linking it from this page 🙏
  2. If you can, could you please write a readme for your own repo? If not, I'll come back to it later and make a pr

@TuanaCelik thank you :))

  1. Will add one soon!
  2. Consider it done ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants