Add llama.cpp Integration #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
bilgeyucel
reviewed
Jan 17, 2024
|
Thank you @awinml! I left some minor comments. Apart from them, it's good to go! ✅ |
Co-authored-by: Bilge Yücel <[email protected]>
ZanSara
reviewed
Jan 18, 2024
There was a problem hiding this comment.
Hey @awinml, I recently made a small PR on this integration, so I suggested a few changes to this PR as well to keep the two in line: deepset-ai/haystack-core-integrations#243
Co-authored-by: ZanSara <[email protected]>
bilgeyucel
approved these changes
Jan 19, 2024
|
@ZanSara This PR is gtg. Feel free to merge it when deepset-ai/haystack-core-integrations#243 is merged 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Part of deepset-ai/haystack-core-integrations#177
Adds Integration page for llama-cpp-haystack.