-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ollama integration tile #108
Ollama integration tile #108
Conversation
Hi @AlistairLR112, thank you for the PR! I'll review it as soon as possible 🙌 |
Wait until deepset-ai/haystack-core-integrations#170 approved :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only left some minor comments.
@bilgeyucel please do the actual review (when you can)
Co-authored-by: Stefano Fiorucci <[email protected]>
Co-authored-by: Stefano Fiorucci <[email protected]>
Co-authored-by: Stefano Fiorucci <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @AlistairLR112! I left some minor comments.
One more comment: can you change the logo something with a background (maybe white)? We're using a dark background for logos and the with transparent bg won't be visible
Co-authored-by: Bilge Yücel <[email protected]>
Co-authored-by: Bilge Yücel <[email protected]>
Co-authored-by: Bilge Yücel <[email protected]>
Co-authored-by: Bilge Yücel <[email protected]>
Hi @AlistairLR112 and @anakin87 - thanks both for your contribution here! We will aim to announce this on Monday. @AlistairLR112 - please let me know if there's a twitter/LI account you'd like tagged. Also, if you have a demo or want to showcase this integration, we can help with that too. |
Hey @TuanaCelik! Could you tag my linkedin here? |
@AlistairLR112 and @anakin87, looks like you guys had all the fun without me :) , |
Adding tile for ollama integration - https://github.com/deepset-ai/haystack-core-integrations/tree/main/integrations/ollama