Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ollama integration tile #108

Merged

Conversation

AlistairLR112
Copy link
Contributor

@bilgeyucel bilgeyucel self-requested a review January 4, 2024 13:17
@bilgeyucel
Copy link
Contributor

Hi @AlistairLR112, thank you for the PR! I'll review it as soon as possible 🙌

@AlistairLR112
Copy link
Contributor Author

Wait until deepset-ai/haystack-core-integrations#170 approved :)

Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only left some minor comments.
@bilgeyucel please do the actual review (when you can)

integrations/ollama.md Outdated Show resolved Hide resolved
integrations/ollama.md Outdated Show resolved Hide resolved
integrations/ollama.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AlistairLR112! I left some minor comments.

One more comment: can you change the logo something with a background (maybe white)? We're using a dark background for logos and the with transparent bg won't be visible

integrations/ollama.md Outdated Show resolved Hide resolved
integrations/ollama.md Outdated Show resolved Hide resolved
integrations/ollama.md Outdated Show resolved Hide resolved
integrations/ollama.md Outdated Show resolved Hide resolved
integrations/ollama.md Outdated Show resolved Hide resolved
integrations/ollama.md Outdated Show resolved Hide resolved
@TuanaCelik
Copy link
Contributor

Hi @AlistairLR112 and @anakin87 - thanks both for your contribution here! We will aim to announce this on Monday. @AlistairLR112 - please let me know if there's a twitter/LI account you'd like tagged. Also, if you have a demo or want to showcase this integration, we can help with that too.

@TuanaCelik TuanaCelik self-requested a review January 5, 2024 12:06
@TuanaCelik TuanaCelik merged commit a15e09d into deepset-ai:main Jan 5, 2024
@AlistairLR112 AlistairLR112 deleted the feature/ollama_integration_tile branch January 5, 2024 14:22
@AlistairLR112
Copy link
Contributor Author

Hey @TuanaCelik! Could you tag my linkedin here?
https://www.linkedin.com/in/alistairlr/

@sachinsachdeva
Copy link

@AlistairLR112 and @anakin87, looks like you guys had all the fun without me :) ,
hopefully we get a chance again .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants