Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog #88

Merged
merged 31 commits into from
Mar 3, 2023
Merged

Blog #88

merged 31 commits into from
Mar 3, 2023

Conversation

carlosgauci
Copy link
Collaborator

@carlosgauci carlosgauci commented Feb 16, 2023

@TuanaCelik @bilgeyucel here's the first draft of the blog. I've left the placeholder/test posts there for now.

Blog listing page - the newest post is larger at the top and it's paginated at 10 posts (9 on the frontpage), this can be changed from config.toml

Blog post - the body here is the same as the tutorial posts so anything that works there will work here like codeblocks etc. The content is a bit wide for a blog post since there's no right sidebar, we should probably make it narrower to be more readable?

Author page - used the same hero as the tutorials/blog here, not sure if it looks good, lmk what you think and we can change it if not.

@vercel
Copy link

vercel bot commented Feb 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
haystack-home ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 3, 2023 at 0:20AM (UTC)

Copy link
Member

@TuanaCelik TuanaCelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @carlosgauci - this all looks good to me, I have a couple of questions:

  • would it be possible to make the social logos on the blog post itself next to the author names too? I the Haystack purple?

image

  • Could we make the social logos on the author pages white? Just for the aesthethic? :)
  • Also, a question we had from our side: Do you have best practice recommendations for handing assets per author and blog? Should we create a folder in static/images/blog-name ? And add all the images for a given blog there? Any comments on how to best maintain those?

@carlosgauci
Copy link
Collaborator Author

Hey @TuanaCelik,

I've added white and dark versions of the social icons, and added social links to the blog posts. In case you wanted to try some different colors, you can edit the SVGs and change the "fill" property to change the color.

For the images, it's mostly personal preference, you can either use one static folder or split them up as you said. Putting them in the same folder is probably easier if you plan to reuse a lot of images between posts, else if you prefer to be more organized you can split them.
I was also trying to implement the option of putting them in a folder with the blog post, so instead of /blog/post-slug.md, you would have /blog/post-slug/index.md, and put all the images for that post inside the /post-slug/ directory. For some reason the image paths aren't correct when deployed, only locally, so I'm still trying to solve that.

@TuanaCelik
Copy link
Member

TuanaCelik commented Feb 23, 2023

Hey @carlosgauci - I quite like the folder solution that you have for post19 indeed.
We would rarely ever share images across posts so that's also ok.
A few questions: even though the post would be in post_name/index.md it looks like the URLs for the post would still be /blog/post_name correct?
And for each image, we would use ![test](post_name/image.png)
I hope I've got that right. Let me know. @bilgeyucel @masci wdyt about this way of organizing the posts and images?

@carlosgauci
Copy link
Collaborator Author

Hey @TuanaCelik, yep you're correct about the urls.
The images should be working without specifying the post slug since they're in the same directory, so ![test](image.png). it's working locally but not when deployed, because we have trailing slashes disabled through vercel.json. Haven't found a way to enable them for a specific directory, and enabling them site-wide will change old URLs to include a trailing slash so it might affect seo.

@masci
Copy link
Contributor

masci commented Feb 24, 2023

@TuanaCelik I like the idea of organising images under each post. I understand the tradeoff but on my personal website I have all the images in one folder an it's a mess (too late and too lazy to go back) and I would gladly have a few duplicated images in case we need to use the same across multiple posts (very unlikely anyways).

carlosgauci and others added 4 commits February 27, 2023 15:29
* Build a Search Engine with GPT-3, How to Build a Semantic Search Engine in Python, The Definitive Guide to BERT Models
* Center blog content images
* If was creating a problem for my large screen in terms of resolution
@bilgeyucel bilgeyucel merged commit 122e9f1 into main Mar 3, 2023
@bilgeyucel bilgeyucel deleted the blog branch March 3, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants