Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nav link animation, serverless function test #5

Merged
merged 18 commits into from
Sep 22, 2022
Merged

nav link animation, serverless function test #5

merged 18 commits into from
Sep 22, 2022

Conversation

carlosgauci
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Sep 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
haystack-home ✅ Ready (Inspect) Visit Preview Sep 22, 2022 at 7:07PM (UTC)

Copy link
Contributor

@TuanaCelik TuanaCelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sooo good @carlosgauci 🥳

A few minor comments/additions and a small bug report:

  1. Would it be possible to include arrows at the bottom of each tutorial popinting to the next (if there) and previous (if there)?
  2. In safari, we noticed that the arrow on the left is double (see screenshot)
  3. We will use the filter buttons on the top in the future but we're not ready for it yet so they can be commented out for now. When we are using them, it would be nice to have it so that when you click on one for the first time it gets selected and the rest get deselected. Then the user can be free to add any extra filters - we can keep this out from this PR too and keep it for refinements.

image

@TuanaCelik
Copy link
Contributor

I'm happy to merge this PR if you're ready for it @carlosgauci 💪🏽
@masci Wdyt?

@carlosgauci
Copy link
Collaborator Author

I'm happy to merge this PR if you're ready for it @carlosgauci 💪🏽 @masci Wdyt?

Fine with me :)

@TuanaCelik
Copy link
Contributor

Oh actually I do have one question and this might have some impact on how we push tutorial content here @masci
I've just realized that the tutorial levels are also split into their own folders. Do we then display them in separate accordions based on which folder they belong in or is it all determined by frontmatter?

If someone adds a new tutorial will they have to also determine which folder they belong in or is just providing the frontmatter enough?

@carlosgauci
Copy link
Collaborator Author

Oh actually I do have one question and this might have some impact on how we push tutorial content here @masci I've just realized that the tutorial levels are also split into their own folders. Do we then display them in separate accordions based on which folder they belong in or is it all determined by frontmatter?

If someone adds a new tutorial will they have to also determine which folder they belong in or is just providing the frontmatter enough?

I just split them into folders today so they are more organized, but it makes no difference for the accordions, we can revert it back to 1 folder if you prefer.

@TuanaCelik
Copy link
Contributor

I just split them into folders today so they are more organized, but it makes no difference for the accordions, we can revert it back to 1 folder if you prefer.

I think that might be easier for pushing tutorials @masci right?

@masci
Copy link
Contributor

masci commented Sep 22, 2022

Having them all in one folder it's easier for the CI and more flexible (say you want to switch category for a tutorial, that would be one line changed in the frontmatter vs. moving a file around) - I would advocate for a flat structure in a single folder

@TuanaCelik TuanaCelik merged commit 9f34347 into main Sep 22, 2022
@TuanaCelik TuanaCelik deleted the dev branch September 22, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants