-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nav link animation, serverless function test #5
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks sooo good @carlosgauci 🥳
A few minor comments/additions and a small bug report:
- Would it be possible to include arrows at the bottom of each tutorial popinting to the next (if there) and previous (if there)?
- In safari, we noticed that the arrow on the left is double (see screenshot)
- We will use the filter buttons on the top in the future but we're not ready for it yet so they can be commented out for now. When we are using them, it would be nice to have it so that when you click on one for the first time it gets selected and the rest get deselected. Then the user can be free to add any extra filters - we can keep this out from this PR too and keep it for refinements.
I'm happy to merge this PR if you're ready for it @carlosgauci 💪🏽 |
Fine with me :) |
Oh actually I do have one question and this might have some impact on how we push tutorial content here @masci If someone adds a new tutorial will they have to also determine which folder they belong in or is just providing the frontmatter enough? |
I just split them into folders today so they are more organized, but it makes no difference for the accordions, we can revert it back to 1 folder if you prefer. |
I think that might be easier for pushing tutorials @masci right? |
Having them all in one folder it's easier for the CI and more flexible (say you want to switch category for a tutorial, that would be one line changed in the frontmatter vs. moving a file around) - I would advocate for a flat structure in a single folder |
No description provided.