Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tutorial search scrolling #140

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Fix Tutorial search scrolling #140

merged 3 commits into from
Jun 2, 2023

Conversation

TuanaCelik
Copy link
Contributor

Fixes #139

@vercel
Copy link

vercel bot commented Jun 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
haystack-home ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2023 0:08am

@TuanaCelik
Copy link
Contributor Author

@bilgeyucel looks like this works in terms of creating the url. The scroll doesn't always work for me though

@TuanaCelik
Copy link
Contributor Author

oops.. Also the ' has to go

bilgeyucel
bilgeyucel approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@TuanaCelik TuanaCelik merged commit ffea4bc into main Jun 2, 2023
@TuanaCelik TuanaCelik deleted the fix-tutorial-search branch June 2, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilgeyucel bilgeyucel bilgeyucel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix tutorial search headlines
2 participants
@TuanaCelik @bilgeyucel