Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ground truth documents and answers to RAG eval run results as inputs #17

Merged
merged 1 commit into from
Jun 21, 2024
Merged

feat: Add ground truth documents and answers to RAG eval run results as inputs #17

merged 1 commit into from
Jun 21, 2024

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented Jun 21, 2024

Proposed Changes:

The ground truth inputs passed to the RAG eval harness were not being included in the final results. This PR rectifies that.

How did you test it?

Unit test

Checklist

@shadeMe shadeMe requested a review from a team as a code owner June 21, 2024 08:59
@shadeMe shadeMe requested review from anakin87 and davidsbatista and removed request for a team and anakin87 June 21, 2024 08:59
davidsbatista
davidsbatista approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9611045104

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 98.253%
Totals Coverage Status
Change from base Build 9595482629: 0.02%
Covered Lines: 731
Relevant Lines: 744
💛 - Coveralls

@shadeMe shadeMe merged commit 22d3d70 into deepset-ai:main Jun 21, 2024
5 checks passed
@shadeMe shadeMe deleted the feat/rag-eval-harness-gt-inputs-in-results branch June 21, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbatista davidsbatista davidsbatista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@shadeMe @coveralls @davidsbatista