Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct parameter name for faithfulness evaluator and fix component names passed to PipelinePair #13

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented Jun 14, 2024

Proposed Changes:

Fixes:

  • The parameter name for the faithfulness evaluator was outdated.
  • The meta names of the expected components were incorrectly being passed to the to PipelinePair instead of the component names.

How did you test it?

All tests

Checklist

@shadeMe shadeMe requested a review from a team as a code owner June 14, 2024 09:05
@shadeMe shadeMe requested review from anakin87 and removed request for a team June 14, 2024 09:05
@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9513555861

Details

  • 20 of 22 (90.91%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.764%

Changes Missing Coverage Covered Lines Changed/Added Lines %
haystack_experimental/evaluation/harness/rag/harness.py 20 22 90.91%
Totals Coverage Status
Change from base Build 9465387731: 0.0%
Covered Lines: 612
Relevant Lines: 626

💛 - Coveralls

@shadeMe shadeMe requested review from davidsbatista and removed request for anakin87 June 14, 2024 12:07
@davidsbatista davidsbatista merged commit 4fd4b47 into deepset-ai:main Jun 14, 2024
5 checks passed
@shadeMe shadeMe deleted the fix/rag-eval-harness-bugs branch June 14, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants