Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add retry action for integration tests #830

Closed
wants to merge 3 commits into from
Closed

chore: add retry action for integration tests #830

wants to merge 3 commits into from

Conversation

masci
Copy link
Contributor

@masci masci commented Jun 19, 2024

Related Issues

Proposed Changes:

  • Retry the steps of the workflows running integration tests

How did you test it?

Not tested

Notes for the reviewer

  • Given the duplication provided by having many integrations, I thought it would be less invasive to change the CI job instead of the python code for the tests
  • I also fixed the Datadog alert, the conditional on the title wasn't working and I got rid of it entirely across the board. I think it's ok since we receive the link to the failed workflow, from which it's easy to spot what went wrong in particular.

Checklist

@masci masci requested a review from a team as a code owner June 19, 2024 15:24
@masci masci requested review from silvanocerza and removed request for a team June 19, 2024 15:24
@masci masci marked this pull request as draft June 19, 2024 15:26
@silvanocerza silvanocerza removed their request for review June 20, 2024 07:53
@masci masci closed this Jun 21, 2024
@masci masci deleted the retry-flaky-tests branch June 21, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
integration:amazon-bedrock integration:amazon-sagemaker integration:astra integration:chroma integration:cohere integration:deepeval integration:elasticsearch integration:fastembed integration:google-ai integration:google-vertex integration:gradient integration:instructor-embedders integration:jina integration:langfuse integration:llama_cpp integration:mistral integration:mongodb-atlas integration:nvidia integration:ollama integration:opensearch integration:optimum integration:pgvector integration:pinecone integration:qdrant integration:ragas integration:unstructured-fileconverter integration:weaviate topic:CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark integration tests as flaky
1 participant
@masci