Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deepset-ai/haystack-core-integrations#727] #738

Merged
merged 5 commits into from
May 18, 2024

Conversation

jlonge4
Copy link
Contributor

@jlonge4 jlonge4 commented May 16, 2024

Hybrid retrieval example

@jlonge4 jlonge4 requested a review from a team as a code owner May 16, 2024 23:17
@jlonge4 jlonge4 requested review from davidsbatista and removed request for a team May 16, 2024 23:17
@jlonge4
Copy link
Contributor Author

jlonge4 commented May 16, 2024

#727

@anakin87 anakin87 self-requested a review May 17, 2024 08:55
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlonge4 thanks!

I found some small possible improvements...

integrations/pgvector/examples/hybrid_retrieval.py Outdated Show resolved Hide resolved
integrations/pgvector/examples/hybrid_retrieval.py Outdated Show resolved Hide resolved
integrations/pgvector/examples/hybrid_retrieval.py Outdated Show resolved Hide resolved
integrations/pgvector/examples/hybrid_retrieval.py Outdated Show resolved Hide resolved
@anakin87 anakin87 removed the request for review from davidsbatista May 17, 2024 09:10
@jlonge4
Copy link
Contributor Author

jlonge4 commented May 17, 2024

@anakin87 edits made!

Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anakin87 anakin87 merged commit 7141c68 into deepset-ai:main May 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants