Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the local_files_only option available as of fastembed==0.2.7. It … #736

Merged
merged 3 commits into from
May 15, 2024

Conversation

paulmartrencharpro
Copy link
Contributor

fastembed has a new feature "local_files_only" as of version 0.2.7 (see qdrant/fastembed#229). It allows to use the model files that were already cached without looking online if there is a new version.
This change allows to optionnaly use this feature on the fastembed embedders (FastembedTextEmbedder, FastembedDocumentEmbedder, FastembedSparseTextEmbedder, FastembedSparseDocumentEmbedder).

…allows to not look for the models online, but only use the local, cached, files.

This way, we can download the model once then use this without internet access
@paulmartrencharpro paulmartrencharpro requested a review from a team as a code owner May 15, 2024 12:49
@paulmartrencharpro paulmartrencharpro requested review from davidsbatista and removed request for a team May 15, 2024 12:49
@CLAassistant
Copy link

CLAassistant commented May 15, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added integration:fastembed type:documentation Improvements or additions to documentation labels May 15, 2024
@anakin87 anakin87 self-requested a review May 15, 2024 12:54
@anakin87
Copy link
Member

@paulmartrencharpro thanks for the contribution!

I will have a proper look later.

In the meantime:

  • please sign the CLA
  • fix linting errors: you can try fixing them automatically with hatch run lint:fmt

@paulmartrencharpro
Copy link
Contributor Author

Hello,

CLA signed & lint fixed

Thanks

Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added the same parameter to Document Embedders.
Merging now...

Thanks!

@anakin87 anakin87 merged commit 6f298ce into deepset-ai:main May 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:fastembed type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants