Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bump chromadb dep to 0.5.0 #700

Merged
merged 3 commits into from
May 2, 2024

Conversation

jongirard
Copy link
Contributor

Description

Bump version of chromadb to latest (0.5.0) which contains several improvements, for example, the addition of new embedding functions such as OllamaEmbeddingFunction.

Previously version was pinned to <0.4.20 due to broken filtering tests. This appears to have been caused due to a variance in assert_documents_are_equal expected/received data (unsorted list) which has now been resolved in this PR.

@jongirard jongirard requested a review from a team as a code owner April 30, 2024 07:38
@jongirard jongirard requested review from anakin87 and removed request for a team April 30, 2024 07:38
@CLAassistant
Copy link

CLAassistant commented Apr 30, 2024

CLA assistant check
All committers have signed the CLA.

@jongirard jongirard marked this pull request as draft April 30, 2024 08:19
@jongirard jongirard requested a review from anakin87 May 1, 2024 02:16
@jongirard jongirard marked this pull request as ready for review May 1, 2024 02:16
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@masci masci merged commit ca87b0e into deepset-ai:main May 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants