FastembedSparseTextEmbedder - remove batch_size
#688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:fastembed
type:documentation
|
@masci Do we have a deprecation policy for core integrations? This is a breaking change. |
anakin87
changed the title
FastembedTextEmbedder - remove batch_sizeFastembedSparseTextEmbedder - remove batch_size
|
I agree that formally this is a breaking change. However, this component was released 2 weeks ago and it has not yet been documented or promoted. In any case, let's wait for Massi's opinion. |
|
I talked with Massi: breaking changes are allowed in major releases. Once this PR is merged, I will create a major release of When we have release notes for core integrations, everything will be clearer. |
shadeMe
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FastembedTextEmbeddercan only accept and process a string at a time.batch_sizeparameter is practically ignored and misleading -> I'm removing it.(Other minor docstrings improvements)