Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly deserialize Pinecone docstore in embedding retriever #636

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented Apr 2, 2024

Also add some feature gates to tests

@github-actions github-actions bot added integration:pinecone type:documentation Improvements or additions to documentation labels Apr 2, 2024
@shadeMe shadeMe marked this pull request as ready for review April 2, 2024 11:05
@shadeMe shadeMe requested a review from a team as a code owner April 2, 2024 11:05
@shadeMe shadeMe requested review from masci and anakin87 and removed request for a team and masci April 2, 2024 11:05
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shadeMe
Copy link
Contributor Author

shadeMe commented Apr 2, 2024

Test failures are unrelated and will be fixed in another PR.

@shadeMe shadeMe merged commit 958f44c into main Apr 2, 2024
4 of 6 checks passed
@shadeMe shadeMe deleted the fix/pinecone-serde branch April 2, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:pinecone type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants